JMS55

Results 362 comments of JMS55

Followup tasks: https://github.com/bevyengine/bevy/issues/11518

Sadly moving to 0.14 :(. I'd really like to avoid merging any other rendering PRs until this one is merged once 0.13 releases though, as it's going to be a...

Hey @yzsolt. That comment is outdated. There's since been a more active fork of your crate, which is what I've been using: https://github.com/gwihlidal/meshopt-rs, under the name `meshopt`. I appreciate the...

Oh right, sorry, it's been a while since I looked at things. Yes, you're right, the crate I'm using is a C-wrapper and not pure Rust. Apologies for the confusion....

https://github.com/bevyengine/bevy/pull/11904 has changed the core shader code, going to need to rebase all the shader work on top of that :/

Oh btw, did we document anywhere that specular occlusion doesn't work on webgl2, and it'll use diffuse instead? If not, please add that to the StandardMaterial docs.

Ah right. Docs on either the PbrInput in the shader or in SSAO, or in deferred would be fine, up to you where you think it's best. I just think...

Can't reproduce. Both after the latest commit c4e791d62890cc02773564bad7592345d2b8f05c, or going back ~5 commits. Windows 11 AdapterInfo { name: "NVIDIA GeForce RTX 3080", vendor: 4318, device: 8710, device_type: DiscreteGpu, driver: "NVIDIA",...

Haven't looked at the PR beyond quickly skimming the code, but I'd like more documentation from the user's perspective. I'm not familiar with parallax mapping - it's some kind of...