JMS55 comments

Results 362 comments of


                                            JMS55

Bevy depends on 4 different versions of the windows crate

We're currently down to 3 copies (2 outdated) 1. One will be fixed by updating accesskit_winit https://github.com/bevyengine/bevy/pull/11466 2. One of them needs rodio->cpal to update their windows dependency

Implement minimal reflection probes (fixed macOS, iOS, and Android).

Rather than a conditional cfg, can you move it to a runtime check if the device supports the texture binding array feature?

Implement minimal reflection probes (fixed macOS, iOS, and Android).

@pcwalton thanks for updating this. Hate to do this to you, but this will require some work to rebase now that we merged exposure settings...

Implement opt-in sharp screen-space reflections for the deferred renderer.

In the SSR example, disabling SSR turns off both the cube reflection, but also the reflection on the water from the env map, which surprises me.

Implement opt-in sharp screen-space reflections for the deferred renderer.

Oh I guess doesn't have to be this PR, but it's probably better to use a compute shader for SSR.

Bloom causes massive performance hit (>50% framerate reduction)

RenderDoc is not really a great GPU profiling tool. You'll want to use NSight/RGP/Xcode/GPA/etc (Nvidia, AMD, Apple, Intel) depending on your GPU manufacturer. CPU metrics are also important for rendering...

Bloom causes massive performance hit (>50% framerate reduction)

On my system, at 1080p, it takes 355 microseconds on the CPU (according to Tracy) to encode rendering commands for bloom, and 0.20ms of GPU time (according to NSight) to...

Bloom causes massive performance hit (>50% framerate reduction)

Yes I don't see much of a slowdown between bloom on/off. Just to check are you only toggling bloom? You're leaving tonemapping and Camera::hdr the same between runs?

Mesh is missing requested attribute: Vertex_Normal error

The issue is here: https://github.com/bevyengine/bevy/blob/13cac2eeff7e3c4da7ae636ba3766f59b4e343d0/crates/bevy_pbr/src/prepass/mod.rs#L402

Meshlet single pass depth downsampling (SPD)

The downsample shader, yeah. I can't post a link ATM, but you can find the full PR diff by changing the GitHub diff to compare against my meshlet-previous-frame-depth-pyramid branch.