Josh Borrow

Results 53 comments of Josh Borrow

There's also `Solar_Mass` which in some ways addresses this issue. It would be nice to define `unyt.msun` as `1 * unyt.Solar_Mass` (or as an alias for it, actually). P.S. There...

Another possible issue is that the referenced pdf sheet is no longer available.

I guess these are fundamentally different issues though, `name` is an attribute on `unyt_array` that we are just choosing not to store in the pickle.

This is also a problem in Visual Studio Code, IIRC.

@JDusub83 I in general just ignore this, yes. Usually I am working inside a function with type hints: The red underline is telling me that `Mpc` is not found in...

I rebased this on my new kernel improvements branch, so it should be a clean merge. Unfortunately, the diff is still huge as I had to re-write the whole render...

I've fixed the segfault bug. It was due to the variable `remainder` being defined but uninitialised somewhere in global scope. In response to your other comments: 1. Covered 2. Having...

Please can you revert your minor change - it causes merge conflicts with this branch!

Can you provide example code? All of my code repdroduces exactly the mass that I put in.

The particle is fundamentally not below the resolution limit though, its kernel overlaps with strictly two or more cells.