unyt icon indicating copy to clipboard operation
unyt copied to clipboard
verified publisher icon yt-project

Solar Mass value is 'too precise'

Open JBorrow opened this issue 5 years ago • 2 comments

The solar mass equivalence value: https://github.com/yt-project/unyt/blob/711e2ebc22b59984fab1ee4dfcf745184bdb11dd/unyt/_physical_ratios.py#L22 contains too many digits. http://pdg.lbl.gov/2019/reviews/rpp2018-rev-astrophysical-constants.pdf recommends 1.98841e30 kg based on 2019 measurements.

JBorrow avatar Mar 09 '20 13:03 JBorrow

Another possible issue is that the referenced pdf sheet is no longer available.

JBorrow avatar Mar 09 '20 13:03 JBorrow

I think this if fine to be updated, personally. I think this may cause some downstream issues in yt though. @jzuhone thoughts?

ngoldbaum avatar Mar 09 '20 14:03 ngoldbaum