Josh Borrow
Josh Borrow
I have reverted the changes in `rendermodule.c` but not in `c_code.c` as that's un-used anyway. Note that here I've removed `extra_code.c` and re-wrote the contents of that entirely in `sph_kernel.h`.
Is there anything I can do to help this and the other PRs along?
I agree; I only kept the other kernels as they were already present in the file. Would you like me to remove them?
Hi @eddiebergman, there seem to be some missing references in your paper. Would you be able to fix those and re-generate the PDF? Please include a valid DOI for all...
@editorialbot check references
All looks good now @eddiebergman, thank you.
Hi @gomezzz, thank you. I will raise this with the editorial board shortly. In other news, I will be out on vacation until the 24th, so please do not expect...
Hi @woznicak, have you had a chance to start on your review yet?
Thank you @hirzel and @gomezzz for your comprehensive reviews of the package so far! @eddiebergman, please let me know if you expect a response to their comments to take longer...
@gomezzz, I have discussed this with a few people and we are happy with author scope. Thank you for raising this.