Josh Borrow

Results 53 comments of Josh Borrow

Thanks @gomezzz for your review! @eddiebergman, do you have a timeline on which you expect to address the comments?

@woznicak, thank you for initiating your checklist! Do you know when you will have time to complete the review fully? As the other reviewers are almost complete, it would be...

As a note you may wish to use the STIX fonts that look very similar to Times but are fully open. The problem with math rendering is that the usual...

Should this issue not be closed now that v0.0.14 is out and supports pydantic v2?

Will take a look. Based on my initial quick look over the issue, this paper: https://ui.adsabs.harvard.edu/abs/2021arXiv210605281B/abstract will likely be relevant. More soon.

No, we didn't. Though me and Ash did write a paper about this at some point... https://ui.adsabs.harvard.edu/abs/2021arXiv210605281B/abstract

It's very simple, all you're doing is taking the first order integration of the kernel to the grid (e.g. W(r_center_of_pixel, h) being the contribution to that pixel) and turning it...

Hi @ickc, I have tried to address this in #235 that now uses a unified environment for MacOS and Linux builds, and checks if the compilers have the required features....

Right... Is this because of our flags? We should be using something other than -fopenmp?

Another complication here is that we will need to change the build tool to Meson soon. So... This may all be nullified by that change. I don't know very well...