Johannes Schneider
Johannes Schneider
Ok so I can confirm this issue does not exist on Linux.
So the problem is that since Visual Studio is using a multiconfig, there is no defined build type while the project map is being generated in CMake. This change in...
Maybe change title to "refactoring" or "improvements", otherwise people might think it's about actual reflection in rendering :D
https://www.khronos.org/assets/uploads/developers/library/2016-vulkan-devday-uk/4-Using-spir-v-with-spirv-cross.pdf
One the one hand you are right, since those methods actually belong to performance critical code. On the other hand .at would not prevent us from sccessing the methods of...
When creating a PR for this, we could also resolve the following issue: ```cpp ImGUIOverlay(const ImGUIOverlay &) = delete; ImGUIOverlay(ImGUIOverlay &&) noexcept; ImGUIOverlay &operator=(const ImGUIOverlay &) = delete; ImGUIOverlay &operator=(ImGUIOverlay...
Should get methods return a `const` type? Does it even matter?
Also const for references? ```cpp [[nodiscard]] const std::string &name() const { return m_name; } ```
I introduced a lot of stuff which is unnecessary, like `const VkPhysicalDevice &graphics_card`. Vulkan pointers don't need to be const references.
TODO: * [ ] Don't use const in header files at all, only in source files. * [ ] Don't const Vulkan resource pointers like `VkDevice`, * [ ] Don't...