vulkan-renderer icon indicating copy to clipboard operation
vulkan-renderer copied to clipboard

Build type in engine metadata is empty on Windows

Open IAmNotHanni opened this issue 4 years ago • 2 comments

Describe the bug

Inexor Engine, version 0.1.0
Inexor Vulkan-renderer example, version 0.1.0
Configuration: , Git SHA 13e16b7
2021-07-21T20:32:20+02:00

To Reproduce Steps to reproduce the behavior: Start inexor-vulkan-renderer-benchmarks

Expected behavior The git sha is supposed to be displayed

Screenshots grafik

Desktop (please complete the following information):

  • OS: Windows

IAmNotHanni avatar Jul 21 '21 18:07 IAmNotHanni

Ok so I can confirm this issue does not exist on Linux.

IAmNotHanni avatar Jul 21 '21 21:07 IAmNotHanni

So the problem is that since Visual Studio is using a multiconfig, there is no defined build type while the project map is being generated in CMake. This change in meta.hpp.in will simplify and fix it:

#ifndef NDEBUG
constexpr const char *BUILD_TYPE = "Debug";
#else
constexpr const char *BUILD_TYPE = "Release";
#endif

IAmNotHanni avatar Jul 21 '21 22:07 IAmNotHanni