spl: Added token-2022 extensions' wrappers

[harsh4786]

[vercel[bot]]

@harsh4786 is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

[Henry-E]

While this does look good there are spaces in the directory names which is not ideal. ..............................⬇️ spl/src/token-2022 extensions/confidential_transfers.rs

[harsh4786]

You mean this space? or the underscores?

[Henry-E]

Space, like an empty character. It's usually bad to have them in a path. Better to use - or something else to append extension

[harsh4786]

Okay got it, so i make a new pr with the updated directory then it'd be good to go right?

[Henry-E]

It can be the same PR just a new commit to change the path of the files / directories

On Sat, Nov 19, 2022, 11:44 PM harsh4786 @.***> wrote:

Okay got it, so i make a new pr with the updated directory then it'd be good to go right?

— Reply to this email directly, view it on GitHub https://github.com/coral-xyz/anchor/pull/2142#issuecomment-1320993508, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAHMGG6KAVZLOU7XG22YMDWJFQ7PANCNFSM57DTXKTA . You are receiving this because you commented.Message ID: @.***>

[harsh4786]

how about now?

[Henry-E]

Looks good thanks. Will merge soon

[Henry-E]

Just noticed this PR doesn't

• add any imports to the cargo.toml to allow the use of the token 2022 crate
• doesn't add a feature flag for using these features, similar to how serum dex requires a special feature flag
• doesn't have a mod file that exports the functions from the sub directory (at least I think that's what you'd need?)

This just the basic stuff that I've noticed might be missing and would prevent compiling / even accessing the new function, there might be more I didn't spot.

At the very least @harsh4786 you'd need to add a simple test to misc which imports the new token extension features and uses a least one of them. Then you should run into all of the above issues plus maybe more?