Henry-E

Results 170 comments of Henry-E

Space, like an empty character. It's usually bad to have them in a path. Better to use `-` or something else to append `extension`

It can be the same PR just a new commit to change the path of the files / directories On Sat, Nov 19, 2022, 11:44 PM harsh4786 ***@***.***> wrote: >...

Looks good thanks. Will merge soon

Just noticed this PR doesn't - add any imports to the `cargo.toml` to allow the `use` of the token 2022 crate - doesn't add a feature flag for using these...

Would like to merge but having trouble fixing the merge conflicts on the command line - any conflicts in cargo.lock and spl/cargo.toml should both be the reverted to the current...

I removed the changes to the cargo.lock and cargo.toml since we already updated to the latest versions of in previous commits.

@callensm sorry will defer to your opinion on this again

Not sure if can allow backwards incompatible changes just because - i don't understand it lol - there's no tests - there's no changelog or details warning people about what...

This probably isn't going to get included. It's fairly similar to the existing `has_one` syntax just rephrased slightly. Plus with the new `Optional` PR accounts this constraint becomes more difficult...