anchor icon indicating copy to clipboard operation
anchor copied to clipboard

ts: Remove SPL coders from Anchor package

Open acheroncrypto opened this issue 3 years ago • 1 comments

Follow up on #2143, coders in Anchor package is no longer necessary. This is a breaking change, codebases that rely on SPL from Anchor package would need to migrate to the new packages and only import as needed.

acheroncrypto avatar Aug 27 '22 21:08 acheroncrypto

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 27 '22 21:08 vercel[bot]

Not if sure @tomlinton or @callensm is best to check this out

Henry-E avatar Nov 16 '22 15:11 Henry-E

it's my understanding that the spl coders here are mildly broken anyway, so i wouldn't care if they were removed in favor of the official spl packages that have their own encoding/decoding, but would almost certain be a breaking change for many.

callensm avatar Nov 16 '22 16:11 callensm

Cool, thanks for that. A breaking change doesn't sound great for sure. Might be a close then unfortunately.

Henry-E avatar Nov 16 '22 16:11 Henry-E

Cool, thanks for that. A breaking change doesn't sound great for sure. Might be a close then unfortunately.

i'd still consider merging once we get more input of the usability of these coders. if the impact is minimal might be worth getting rid of the bloat /shrug

callensm avatar Nov 16 '22 16:11 callensm

Cool, thanks for that. A breaking change doesn't sound great for sure. Might be a close then unfortunately.

We had a talk about this with @armaniferrante and his input was to completely remove them and allow people to import as needed.

acheroncrypto avatar Nov 16 '22 16:11 acheroncrypto

ok, just verified. we're good to merge this once conflicts are resolved.

I was misunderstanding what was actually being proposed for removal.

callensm avatar Nov 16 '22 16:11 callensm

Great, @acheroncrypto if you wouldn't mind to fix the merge conflicts when you get a chance and will try merge ASAP!

Henry-E avatar Nov 16 '22 16:11 Henry-E

Fixed the conflicts, only zero-copy test seems to fail and it's not related to this PR.

acheroncrypto avatar Nov 17 '22 14:11 acheroncrypto

@acheroncrypto are you happy with merging or any last bits you want to add?

Ha, you posted literal seconds before I did. Will merge so

Henry-E avatar Nov 17 '22 14:11 Henry-E