Giedrius Statkevičius

Results 227 comments of Giedrius Statkevičius
trafficstars

Maybe https://github.com/cristalhq/hedgedhttp/blob/main/hedged.go#L40-L41 `*http.Request` could be exposed to `NextFn` and then `Next` could return `0` when `req.Method == "POST"` (etc.)?

I guess it's a task to completely automate the steps in the release process so that this wouldn't happen. I guess that for none of the maintainers this hurts so...

IIRC rough agreement on Slack was that there was never a promise that the response will be sorted and it was just a coincidence that we get a sorted response.

Just a few hours ago a PR was merged that assumes that the response is sorted: https://github.com/prometheus/prometheus/pull/11379/files#r1734323519 :grimacing:

> > Even if I am using Prometheus Agent then I still want to see scraping targets in one central location i.e. Thanos Query. > > I am wondering if...

Have you considered using some alternative and perhaps more efficient admission/eviction policies like TinyLFU or some others?

Disappeared where exactly? On the router? If yes then my understanding is that the router isn't writing anything itself hence those metrics shouldn't have ever existed in the first place.

v1.21.0 is out so this should be doable now 🚀

Could you add a goroutine dump when this happens through /debug/pprof?