Giedrius Statkevičius

Results 230 comments of Giedrius Statkevičius
trafficstars

Please update to the latest version and try again. Is it reproducible?

I think we would need the query + labelsets returned by each vector selector to be able to debug this.

Why did you mark the function "rate()" as unfinished? :thinking:

What do you think about adding a new option for a query such as `RecordDuration bool` as a starter which would tell the engine to capture the used time by...

Please apply on the LFX website 🤗

@ConnectBhawna you can try compiling and running Thanos locally as per instructions on https://thanos.io/tip/thanos/getting-started.md/. Then, you can try switching to this engine with `--query.promql-engine=thanos` and explore the code in this...

In my opinion, there are two ways of going around this: embedding observability information into each operator that implements `VectorOperator` interface (and making `ObservableOperator` interface that extends `VectorOperator` and allows...

Be careful with (2) because you might run into https://github.com/grafana/mimir/issues/2599. Not sure what would be a good way to solve that.

Mhm, it sounds like that could work! It will complicate the implementation, of course, but it should solve that issue. Perhaps it would also be cool to implement this in...

Perhaps a simpler approach would be the 2nd option https://github.com/thanos-community/promql-engine/issues/106#issuecomment-1475815093 here to avoid extending the interface?