thanos
thanos copied to clipboard
thanos-io
Disable StoreAPI if agent enabled
Is your proposal related to a problem?
Even if I am using Prometheus Agent then I still want to see scraping targets in one central location i.e. Thanos Query.
Describe the solution you'd like
Sidecar should check whether Agent mode is enabled and if that is true then disable StoreAPI.
Describe alternatives you've considered
Don't have scraping target info in the querier? ;D I don't think there's any alternative.
Additional context
N/A
Even if I am using Prometheus Agent then I still want to see scraping targets in one central location i.e. Thanos Query.
I am wondering if there are other systems that also expose targets API and want to federate using Thanos Query. In this case a flag to disable store API sounds a better option.
Even if I am using Prometheus Agent then I still want to see scraping targets in one central location i.e. Thanos Query.
I am wondering if there are other systems that also expose targets API and want to federate using Thanos Query. In this case a flag to disable store API sounds a better option.
I think this can be done independently in the future if such use-case comes up. For now I'd like Thanos to disable StoreAPI automatically if Prometheus Agent is detected. We should strive to keep the number of flags as small as possible :smile:
@AryanSharma9917 feel free to work on this.
hello @GiedriusS I hope this message finds you well. I'm excited to introduce myself as a new member of the Thanos community. I'm eager to contribute to the organization and help enhance the project. If possible, could you please consider assigning me this issue , I am also open to any guidance or feedback you can provide during the process.
hello @GiedriusS I hope this message finds you well. I'm excited to introduce myself as a new member of the Thanos community. I'm eager to contribute to the organization and help enhance the project. If possible, could you please consider assigning me this issue , I am also open to any guidance or feedback you can provide during the process.
Hey @Vanshikav123, I have started working on this issue. If I fail to solve this issue I'll make sure to let you know till then you can look into some other issues like good first issues and help wanted.
Hey @AryanSharma9917
Are you still working on this?
I have come up with a solution for it, If you are fine can I open the PR?
Hey @AryanSharma9917
Are you still working on this?
I have come up with a solution for it, If you are fine can I open the PR?
Sure @Vanshikav123, go ahead..!!
Hello @AryanSharma9917 I think I headed to find the solution for this issue in wrong direction sorry for the inconvenience I will work on this and try to figure out how this could be solved until then you are welcomed to work on this and solve it . Thank you!
