Giedrius Statkevičius
Giedrius Statkevičius
> > The fix itself LGTM but now that we know about this bug, the `Hash` field in `*storepb.Chunk` becomes kind of useless. Perhaps we could add a Hash field...
Maybe you could try the version from `main` in your tests and check whether https://github.com/thanos-io/thanos/commit/daa34a52cc41d609d184013707c55f0ad28b60e2 helps? :thinking:
I guess https://github.com/prometheus/prometheus/issues/13302 is partially related?
It sounds like the TCP connection gets closed. Does it work if you `telnet` (or `netcat`) the same IP/port?
I have continued the fork here: https://github.com/vinted/prometheus/tree/xrate_2.33.1. The tests pass so it _should_ be OK.
cc @akanshat
Thank you for your thorough review, we will try the epochs approach and come back to you.
Is it the same if you specify the timestamp? How could we reproduce this?
Please see https://github.com/thanos-io/promql-engine/pull/325/files and others for a previous attempt at this. We either want to have an improved Select() interface or pass these hints through `context.Context` somehow.
There are still some missing things: https://github.com/thanos-io/promql-engine/pull/325/files#diff-5b6024dfabe0bc120c9efaad778c55c7283d643c0ad2882eb7e47effa7aac384R24. Also, that PR needs some tests. There was also a suggestion to just pass Select() metadata through `context.Context`. Perhaps it could be a...