thanos
thanos copied to clipboard
ruler: Add flag to configure the queue for pending Alertmanager notif…
- [x] I added CHANGELOG entry for this change.
- [ ] Change is not relevant to the end user.
Changes
Add flag to configure the queue for pending Alertmanager notifications In the prometheus package we are already able to configure the capacity size. The fixed value could lead to issues sending alerts when evaluating a huge amount of alerts in one ruler instance.
Failing test seems unrelated to my changes and might be flacky.
Unfortunately, I don't know what a “good” value is or should be. Both the implementation in Thanos and the implementation in Prometheus don't mention anything about this. That's why I would just leave the default and make it configurable as needed.
We can also set the flag to hidden if you prefer.
I think let's then make it hidden :+1:
I have made the flag hidden :smile:
Failing test seems again unrelated to my changes and might be flacky.
@GiedriusS can this get merged?
@GiedriusS i have rebased the branch to get this thing merged. Failing tests are flacky and not related to my changes.
@GiedriusS any updates on getting this merged?