(Jip) Willem Wijnia

Results 464 comments of (Jip) Willem Wijnia

Good question, I can't recall. Not sure if I end up doing that in the end. Given the amount of changes for the next release (which is on Sunday) I'll...

#3144 branched out a bit too much. Some of its functionality is already implemented by other PRs. I'll review this one tomorrow.

This is looking good - I'll review it again on Friday.

When a user has a faulty mod enabled it prevents the entire lobby from functioning: ```yaml WARNING: SCR_LuaDoFileConcat: Loading "c:\programdata\faforever\user\my games\gas powered games\supreme commander forged alliance\mods\battle-royale\lua\ai\lobbyoptions\lobbyoptions.lua" failed: ... forged alliance\mods\battle-royale\lua\ai\lobbyoptions\lobbyoptions.lua(9):...

I missed the notification! The logic of the explosions are defined in the projectile script: - effects/Entities/SCUDeathAeon/SCUDeathAeon_script.lua - effects/Entities/SCUDeathCybran/SCUCybranDeath_script.lua - effects/Entities/SCUDeathSeraphim/SCUSeraphimDeath_script.lua - effects/Entities/SCUDeathUEF/SCUUefDeath_script.lua You can scale the effects independently using...

Took a while, but here we are. Had a subtle issue in it. The primary discovery for me in this pull request is that `SimUtils` essentially only exists for the...

I don't know what half of the statistics that you included means in practice. I'll have to look that up 😄 ! I don't have any initial feedback on the...

Absolutely great work 👍 , I hope this changes our perception as to what is and is not a performance improvement. In particular, using upvalues to cache a table access...

``` WARNING: Error running OnMouseoverItem script in CScriptObject at 1b4a0c00: ...\jip\documents\delete-me\fa\lua\ui\game\profiler.lua(927): attempt to call method `AddressToString' (a nil value) stack traceback: ...\jip\documents\delete-me\fa\lua\ui\game\profiler.lua(927): in function `BytecodeTooltip' ...\jip\documents\delete-me\fa\lua\ui\game\profiler.lua(677): in function ```` It...

Could you try and sandbox a crash, or a set of steps to reliably reproduce it?