Adrián Chaves
Adrián Chaves
I am starting to think maybe we should not make any change code-wise here, and instead make sure the documentation explains clearly what @GeorgeA92 covered above. On a related note:...
Probably not, but I want to take some time to have a proper look at this one. I hope it does not take me too long to find the time.
I wonder if instead of `@basespider` we should name the decoration something else that clearly indicates that the end result is simply that Scrapy won’t load it. I cannot think...
I am not sure what the best approach is. I mean, ideally the user should not set the `Content-Length` header at all, and let Scrapy (Twisted) do that. If a...
Is it OK to set the attribute after the class initialization, instead of passing it to the class __init__ method? Could you include some kind of test for the change...
We have a few tests that may fail randomly. Let me re-run them.
According to the [pull request coverage report](https://app.codecov.io/gh/scrapy/scrapy/compare/5406/diff) it gets called at least 6 times. So I think we can ignore the codecov/patch issue.
I wonder if we can exploit mitmproxy for a testing SMTP server, as we do for other tests that need a server.
I would rather link to `https://docs.scrapy.org/en/latest/contributing.html#reporting-bugs` so that we have a single source of truth about this procedure. Maybe we can first restructure that part of the documentation so that...
Why `NamedTemporaryFile` instead of `mkstemp`?