Adrián Chaves
Adrián Chaves
@Dushatar Please, have a go at it, and let us know if you need any help :slightly_smiling_face:
It’s quite a good start, but it would need some adjustments to get merged. It should definitely make things easier for the next person that comes around.
> After changing files on my machine how can I check if this is causing some errors or is it ok to push and later create a pr? [You can...
There is https://github.com/scrapy/scrapy/pull/5480 already, pending review. You could review it and give your thoughts.
Sounds great! Make sure you check out the links in https://github.com/scrapy/scrapy/issues/5408
@OrestisKan Sounds great.
@atatabitovska That documentation link you provide is not for Scrapy itself, but for a third-party plugin, so Scrapy itself does not support cookie storage. I would usually not suggest reimplementing...
> The guidelines stipulate that I need a prior pull request. Is this satisfactory? It is enough to meet that requirement, yes (and, in any case, getting the pre-application pull...
Ideally we should include a test before merging. I wonder if subprocess with shell=True will allow to write a test for this. PS: Closing and reopening to trigger a new...
I assume signal handlers are executed in the order in which they are connected to signals. What you need to know in order to know the order of execution of...