Adrián Chaves

Results 860 comments of Adrián Chaves

Can you tell me what’s the first line that your changes add?

It is not. You are adding another line earlier.

Consider them pinged. Let me get back to you later this week.

Sorry, I almost forgot. I’ll try to handle it today.

Isn’t there a way to fix this that is not PyInstaller-specific? I wonder why https://github.com/scrapinghub/dateparser/blob/f69e9b2e11c81ded87ec80956bcf42c297e9366c/MANIFEST.in#L6 is not enough for PyInstaller to include the file.

[I see PyInstaller maintainers decided against doing this automatically](https://github.com/pyinstaller/pyinstaller/issues/2065), and [they seem to want packages to provide hooks](https://pyinstaller.org/en/stable/hooks.html). I am not against it, but I don’t plan to work on...

Generating on the first import would not solve that, you could install a new regex version after that. Either we find a way to avoid the regex issue, or we...

Closing and reopening to see if CI triggers.

It seems tests do not pass. ``` a = (,) kw = {} @wraps(func) def standalone_func(*a, **kw): > return func(*(a + p.args), **p.kwargs, **kw) E TypeError: test_relative_past_dates() got an unexpected...