Adrián Chaves

Results 860 comments of Adrián Chaves

I think this issue can be closed, provided no code from Modest is copied into this library, and instead it is simply used through its API. See https://softwareengineering.stackexchange.com/a/141848/67648

I do it manually in a commit right before running `bump2version`.

Re-running failing jobs…

@GeorgeA92 https://github.com/scrapy/scrapy/pull/5328#discussion_r804581877 is still unaddressed.

Would the current implementation work if you did the following? ```python self.bar = foo.bar ```

I see, the problem is that `Utilities.bar` yields requests with `callback=self.bar`. As a workaround for the new example, you could initialize `Utilities` with a reference to the spider, and then...

> [The fix I am proposing is] not a major change and solves a limitation that doesn't need to be there. We can still discuss and potentially merge your change...

Note: macOS failures occur at random at the moment, we are considering disabling them temporarily until we find a solution. Feel free to ignore them.

I’ll close and reopen to force tests to run with the latest changes to `master`.

To address @ejulio’s concern about priority not being taken into account, maybe we could have the dequeuing not yield requests from the delay queue, but instead feed them into the...