Adrián Chaves
Adrián Chaves
@Langdi Hey, this pull request seems close to being ready, do you plan to continue working on it?
@Langdi Do you think you will have time to fix those two minor comments I left? Also, it would be great if you could rebase your changes to solve the...
You assumption was quite correct :slightly_smiling_face: ; we still need someone else to review this, which may take some time.
The missing coverage is due to a line of the deprecated `create_root_node` which I don’t know how to reach. Since the implementation of the function has not changed and should...
Do you think you can include tests that cover the lines marked in yellow/red in https://codecov.io/gh/scrapy/parsel/pull/181/diff?
@EchoShoot Do you plan to get back to this? Otherwise, would you mind if I take over?
To do: - [x] Allow `type` to be `json`. - [x] Allow to specify a `type` for nested XML or HTML structures. - [x] Replace `data` with `root`, given `type`...
I think that would be out of the scope of _this_ pull request, but given js2xml, it does not sound too crazy to implement support for it in the future.
At this point I think the main blocker is deciding the name or names of the method: 1. `jmespath` (current proposal) 2. `jmespath` and `jmes` (what @pauloromeira suggested, which I...
I performed a private survey with people that use Parsel professionally, and choices were 3:1 towards `jmespath` (no one opted for both), so I would say we will probably go...