Adrián Chaves
Adrián Chaves
The docs CI reports: ``` /home/runner/work/scrapy/scrapy/docs/topics/settings.rst:1475: ERROR: Unexpected indentation. [docutils] /home/runner/work/scrapy/scrapy/docs/topics/settings.rst:1476: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] ``` You should run `tox -e docs` to...
> If it is twisted problem, can it be replaced by asyncio? You can use asyncio with Scrapy 2.0. I am not sure that it will fix it, though. It...
Wow, https://twistedmatrix.com/trac/ticket/9766 https://github.com/scrapy/scrapy/issues/4306 might help once implemented, allow to workaround that Twisted issue.
They probably fixed the issue upstream, but the issue still exists on our end. To be clear, this is a case where the server is in the wrong, but if...
Please, see https://docs.scrapy.org/en/latest/contributing.html. > We do not assign issues, and you do not need to announce that you are going to start working on an issue either. If you want...
I wonder if we can rely on something like https://github.com/marrow/mailer, or write a component to support it, to make support for most mail delivery methods easy while minimizing changes in...
> [enforcing valid extras] would affect a lot of people since there are packages out there (mostly old and less updated stuff) with invalid extras. […]. I guess a middle-ground...
We can mitigate this issue in two ways (plus improving docs): 1. **Code fix**: In `Settings.getwithbase()`, drop base keys when the setting value already has them. This should cover the...
Closing and reopening to re-trigger CI. @VMRuiz Maybe you are a better choice to review this change?
The code looks fine to me. The feature, not so sure. I think we need to justify the reason for this feature to exist, and cover that in the docs....