Jeremiah Senkpiel comments

Results 518 comments of


                                            Jeremiah Senkpiel

upgrade deps and run through cargo.toml through prettier

@jbr sorry for not catching this before I made other changes... could you rebase this?

Add body length limiting middleware

While returning something like status 416 may technically be more correct, in case of attack mitigation returning error 400 is probably the most sensible. 403 doesn't seem correct. As for...

Unit testing example

I suggest looking at https://github.com/eaze/preroll/tree/latest/preroll-example/tests for production-grade "unit-integration" tests. It may be a while until this comes closer to Tide itself. Some of this may also end up in https://github.com/jbr/tide-testing

Expose the matched route as an extension on the request

I think this is good, but it could just be a method on `tide::Request` IMO.

Add support for routing on subdomains

I no longer recall the conversation well enough on what @jbr's ideas for this were, only that they were interesting.

Update version numbers in README and docs to 0.17

this will cause the need for a lot of crates to be updated and should be done with caution and probably only when necessary

Does tide plan to support http2?

Tide does not have http2+ support.

Remove Unix Socket on close

Related to https://github.com/http-rs/tide/issues/528 "Graceful shutdown"

initial work on listener configuration

@jbr This seems fine to me - I'd approve it if it weren't a draft

Graceful shutdown

I think the server only shuts down in a `panic!` or due to an external signal, such `SIGINT`, or whatever the Windows equivalents are. I suppose this could possibly be...