Jeremiah Senkpiel comments

Results 518 comments of


                                            Jeremiah Senkpiel

Graceful shutdown

Oh I think I see what you are saying - essentially we should have a way to await all tasks which are still alive, I think?

Graceful shutdown

@GWBasic Can you make at least a draft PR?

Request path in req.uri does not match full path of request for nested servers.

This sounds like a bug but I think it may be tricky to fix.

Request path in req.uri does not match full path of request for nested servers.

@jbr would routefinder help this? I think so, right?

Request path in req.uri does not match full path of request for nested servers.

I agree with that, yeah.

expose Method in tide mod

I think it was suspected that perhaps `Method` would not be so commonly used in Tide as opposed to Surf?

Tide without TCP_NODELAY performs unfavorably in benchmarks

Sorry, I've been too busy using Tide in prod to dig into this. I can tell you from production experience: it is orders of magnitude faster than Node.js for common...

Tide without TCP_NODELAY performs unfavorably in benchmarks

autocannon against your node.js example: ``` autocannon 192.168.0.10:8080 -c 16 -W -w 8 -d 20 Running 20s warmup @ http://192.168.0.10:8080 16 connections 8 workers Running 20s test @ http://192.168.0.10:8080 16...

Tide without TCP_NODELAY performs unfavorably in benchmarks

Linux perf counter stats seem to indicate this is artificial (possibly `TCP no_delay` related): ``` Performance counter stats for 'node benchmark_server.js': 117,093.95 msec task-clock # 2.461 CPUs utilized 469,264 context-switches...

Tide without TCP_NODELAY performs unfavorably in benchmarks

With tcp no_delay enabled via @jbr's draft PR (https://github.com/http-rs/tide/pull/823) I get: ``` Running 20s warmup @ http://192.168.0.10:8080 16 connections 8 workers Running 20s test @ http://192.168.0.10:8080 16 connections 8 workers...