Jeremiah Senkpiel
Jeremiah Senkpiel
I think it would be good to add the computer/copy buttons to the applications list. Requires moving a bunch of code around though.
I think we should just add `aZ1!` to the default required characters. That covers pretty much every website and is trivial to do. I suppose better would be to "require"...
It wants to set it's own fully configured `ClientConfig` but already holds an `Arc`-shared reference, hence this PR. I can imagine other clients may like this as well.
Updated to have `pub fn with_tls_config(self, config: impl Into) ...`
> Why does it hold an `Arc`-shared reference? I'll have to spend more time in the codebase to answer that in an exact way - I don't know offhand, if...
Not quite sure how to make rustdoc link those references correctly? 😕
This PR could just as well be completely unrelated from the other two. This is not _necessary_ but is a common API idom for builder APIs in Rust.
Now that [`#[deprecated]`](https://doc.rust-lang.org/beta/reference/attributes/diagnostics.html#the-deprecated-attribute) is available to 3rd-party crates, would it be possible for for `clap` to pick up the presence of that attribute for displaying this kind thing?
@snproj or @dheeraj-grasshopper are either of you able to make a new release? you are the last two contributors to the project who have made merges...
Sounds reasonable.