Jeremiah Senkpiel comments

Results 518 comments of


                                            Jeremiah Senkpiel

Explicit Tail Calls

I suggest that, since this feature is niche, that the `#[become]` (or similar) annotation alternative be used instead, since it the extra characters are unlikely to be typed by a...

Move req / res prototype extension to a separate repo

Extraction of the logic is almost done, but we also need to decide on where to put the properties. The suggestion was to bundle these into "packs". List of req...

Move req / res prototype extension to a separate repo

The one very easy one is that `render()` should come with the views abstraction. (but it depends on `send()` still...)

Move req / res prototype extension to a separate repo

@NickStefan the pillarjs module this is being extracted to is going to be public soon; I can assure you the implementation is far cleaner than the current. :)

Default responder should not console.error 4xx errors

feat: wrap_connector from builder WantsProtocols1

These PRs are separate because they are in effect all completely unrelated, and could just as well be discovered independently. This one is the most important. Reqwest may not be...

vm: references to context inside objects are not === the original context

@mscdex looks like it. The code throws without that fix. With the fix the assertion still fails.

vm: references to context inside objects are not === the original context

@domenic ... and also this one?