Jeremiah Senkpiel comments

Results 518 comments of


                                            Jeremiah Senkpiel

[tracking] typed headers

Added to list: - [`Referer`](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referer) - [`User-Agent`](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent)

[tracking] typed headers

IMO: implement draft headers under some compile time flag with unstable-like reduced guarantees.

Allow adding context to Result similarly to other Result types

`eyre` also has something like this, we should probably add something similar.

http_types::Error should implement std::error::Error

If you would like to discuss this further, I suggest joining this Zulip thread: https://http-rs.zulipchat.com/#narrow/stream/261411-surf/topic/new.20Error.20type In particular I give a run-down of the problems with the current approach in Surf...

expose Headers::new and Extensions::new

needs a rebase for clippy

expose Headers::new and Extensions::new

I think this could be useful if you could set the headers when constructing a request, at least that would make per-client headers in Surf config a tad nicer under...

expose Headers::new and Extensions::new

Unimportant implementation detail, but feature wise, convenience.

Response::new panics with an invalid `TryInto<StatusCode>`

https://github.com/http-rs/http-types/blob/52cc143762c0bf0d3256c8ca44a8ea37c8e6aa3f/src/response.rs#L62-L64 I believe this is covered under https://github.com/http-rs/http-types/issues/303 and in the future (http-types 3.0) `Response::new()` should instead return a `Result`.

UTF-8 mime-type constants don't work well with browsers' `Accept` header

@yoshuawuyts

Disable default-features for http-types

That isn't true, we re-export some things (e.g. `Body`) which as additional functions based on features, unfortunately. I suspect we could change this without anyone noticing but we should probably...