Fabio Alessandrelli
Fabio Alessandrelli
> Does this apply to the entirety of the TLSOptions class, or just those specific methods? TLSOption is just a configuration, it's the classes that uses it that have the...
I'm not really sure what this unit test is actually covering... seems to me it's just testing a couple of setters and getters, which is honestly not a really useful...
> , it also makes more clear to understand what is happening on the test, because all the "When" and "Verify" are in the same file, and not in the...
I'll be AFK for a couple of weeks, but my previous comment against adding another testing library still stands. There's IMO no point in making HTTPRequest tests completely different from...
My main problem with this is that I find most tests in this PR useless. If I implement a mock setter, and then I test the mock setter, I'm not...
> Friendly remainder As mentioned in https://github.com/godotengine/godot/pull/97262#discussion_r1805889374 : > The problem here is that you keep blocking for a long time and only poll once, while you should only block...
> If a key is being modified by Alt, Shift, Control, or Meta, we don't prevent default. This would reenable most browser shortcuts. I don't particularly like this, games that...
> Compiling the simplest of extensions, a single file single including a single header results in a 2MB library. Example: I tried compiling that extension (plus the proper registration, see...
~So @dsnopek there seem to be a considerable size regression between 4.3 and 4.4 (see my updated comment above).~ See below, WASM-only, due to WASM bigint support (which is required...
Results with `optmize=size` (4.4-dev, `a98d41f62bdb8b7aa903e8e37c1faa48fe8fdae8`): Regular: ``` # scons platform=web target=template_debug optimize=size 960K project/bin/libgdexample.web.template_debug.wasm32.wasm # scons platform=web target=template_release optimize=size 956K project/bin/libgdexample.web.template_release.wasm32.wasm ``` Build profile: ``` 216K project/bin/libgdexample.web.template_debug.wasm32.wasm 212K project/bin/libgdexample.web.template_release.wasm32.wasm ```