godot icon indicating copy to clipboard operation
godot copied to clipboard

Published 20 hours ago • verified publisher icon godotengine

Add unit tests for UDPServer

Open pafuent opened this issue 1 year ago • 3 comments

This PR aims to help "fix" #43440

pafuent avatar Sep 22 '24 03:09 pafuent

@Calinou I addressed all your comments, Could you please review again this PR?

pafuent avatar Oct 10 '24 02:10 pafuent

Friendly remainder

pafuent avatar Oct 17 '24 18:10 pafuent

Friendly remainder

As mentioned in https://github.com/godotengine/godot/pull/97262#discussion_r1805889374 :

The problem here is that you keep blocking for a long time and only poll once, while you should only block for brief periods of time and regularly poll (i.e. multiple times), or you risk of having the same error on other OS configurations.

Faless avatar Oct 18 '24 05:10 Faless

@Calinou I addressed all your comments, Could you please review if I addressed them correctly?

pafuent avatar Nov 12 '24 12:11 pafuent

Thanks!

Repiteo avatar Nov 27 '24 16:11 Repiteo