Dimitri Papadopoulos Orfanos
Dimitri Papadopoulos Orfanos
Because this is the repository for the standalone openfortivpn, adding features unrelated to the standalone case is not really an option. Let me try to find some common ground. My...
I think Sourcery applies linter rules, but rules that might not be part of ruff (yet). More importantly, I think Sourcery is a good addition - AI assistance for PR...
I have added Pylint to CI. Adding it to pre-commit is discouraged because it is slow and incompatible with pre-commit parallelisation: * [Pre-commit integration](https://pylint.pycqa.org/en/stable/user_guide/installation/pre-commit-integration.html)
I can add a repo-review pre-commit hook if you're interested: https://pypi.org/project/sp-repo-review/
I ran [`scripts/update_ruff.py`](https://github.com/pypa/hatch/blob/master/scripts/update_ruff.py) which added them automatically. Doesn't it do the right thing? Besides, most of them have not been added in this PR. I believe the intent has always...
I think the new CI failures are unrelated to this PR.
I would be great to rely on a recent version of EDFlib. Not sure how to extract the patches that need to be re-applied onto a new version.
So, if I understand you correctly, the C files contain more additions than actual changes. Maybe I'll give it a try.
Modifying the functionality of a C function does require to modify its source code. Perhaps I can write an additional C function that runs extra code before/after calling the original...
There is no `v3` branch in `numcodecs`, is there? This is `numcodecs`, not `zarr-python`.