Defeatomizer

Results 163 comments of Defeatomizer
trafficstars

Were you granted permission to trigger workflows?

Wouldn't you mind if I'll be helping with other feature blocks in case I find some free time?

>With 1.19 releasing soon, I'm fine with this being merged after we drop support for 1.16 2022.2 is planned to be a feature update, so you probably can proceed keeping...

:man_facepalming: ``` > Task :compileJava /tmp/mcreator_test_workspace730307295436119139/src/main/java/net/mcreator/test_mod/procedures/TestProcedureBlockspawn_entity_with_rotationProcedure.java:35: error: no suitable constructor found for FishingBobberEntity(net.minecraft.entity.EntityType,net.minecraft.world.World) Entity entityToSpawn = new FishingBobberEntity(EntityType.FISHING_BOBBER, (World) world); ^ constructor net.minecraft.entity.projectile.FishingBobberEntity.FishingBobberEntity(net.minecraft.world.World,net.minecraft.entity.player.PlayerEntity,int,int) is not applicable (actual and formal argument...

>Also, if it has a behavior different enough, you should add tests for them. >To do: >* Figure a way to add/skip tests for new input types (the only good...

>Can you provide an example? GitHub feels better now, there you go (check the description). >Also, if it has a behavior different enough, you should add tests for them. The...

I just checked the advanced inputs PR and it didn't provide tests for these dependency provider inputs too. Also, afair blocks that require extra APIs are not tested. The feature...

Is this valid enough to be unmarked as **on hold**?

I'd implement this like item properties: a list of [accessor-defaultvalue] and a list of [accessorscombination-texture]. But the PR will then need the `StateEditor` to define combinations list, I consider separating...