Defeatomizer

Results 163 comments of Defeatomizer
trafficstars

**GitHub Actions**, are you still here? Over!

>??? What? They don't respond to you for nearly 3 hours now, I wonder if they are actually online.

``` /tmp/mcreator_test_workspace7894544345961299972/src/main/java/net/mcreator/test_mod/init/TestModModTrades.java:27: error: cannot find symbol if (event.getType() == TestModModVillagerProfessions.EXAMPLEVILLAGERPROFESSION_7.get()) { ^ ``` 1. Please rename `${JavaModName}ModVillagerProfessions` to `${JavaModName}VillagerProfessions` and `${JavaModName}ModTrades` to `${JavaModName}VillagerTrades`; 2. Do you even generate `${JavaModName}ModVillagerProfessions`?

Of course I meant the classes generated, not the templates.

Then I wonder who is. This is from the most recent tests - `${JavaModName}ModTrades` tries to locate `${JavaModName}ModVillagerProfessions` and this crashes Gradle: ``` /tmp/mcreator_test_workspace3814412695927150266/src/main/java/net/mcreator/test_mod/init/TestModModTrades.java:27: error: cannot find symbol if (event.getType()...

https://github.com/MCreator/MCreator/blob/761a1ccdb7e2fc306356fa048a26e4164abbc4e9/src/test/java/net/mcreator/integration/TestWorkspaceDataProvider.java#L1616 You're using the wrong class (`VillagerProfession` instead of `ProfessionEntry`).

Other validators don't have docs.

>Also while I appreciate small PR, adding classes not used anywhere can't really be done as one can't review them without use context #2000 and block states, I moved these...

These features are all extracted from item properties PR, you can test that one to test these classes.

>It isn't snakecased in the `Feature` class because that would be against Java naming conventions Sorry, I meant the `generateDimensions` field of the template, it should be `generate_dimensions`.