Defeatomizer

Results 163 comments of Defeatomizer
trafficstars

> If it is too uncommented and convoluted Comments :man_facepalming:

Exactly what I fixed locally but didn't push a commit with.

> Please test in-game too to double-check. Thanks! I'm afraid I'll have to skip that part ![image](https://github.com/MCreator/MCreator/assets/71347607/ccbf1cc7-5480-4f19-9e94-7c35c6ef450b) This is holding for a few minutes now and doesn't seem to be...

OKay, it did load. Failed when trying to find ForgeGradle of version 6.0 to 6.2 :man_shrugging:

Gradle doesn't want to help with in-game testing. I just don't know how to make it build fine.

These extra days will postpone both PRs for who knows how many more versions though :pleading_face:

So _this_ time tests did not catch something? (They should have, I see the code)

But after that you'd see the PR has nothing left to be resolved.

Can we be sure `TabEntry` is not null?

Ah, now I see why: ![image](https://github.com/MCreator/MCreator/assets/71347607/c9c6c1e9-5f32-40e7-83b5-65b9df95dc3b) `ITabContainedElement#getCreativeTab()` is annotated with `@Nullable` so we have to deal with that all the way.