Jannik Tappert
Jannik Tappert
This PR is ready to be reviewed/merged by a dev.
> This PR is ready to be reviewed/merged by a dev. Walker says this is fine. See https://discord.com/channels/1125469663833370665/1243948971110694982
Now it is consistent and breaks after || or && if it would be to long without the break
You should test it!
> When I get the shiny party achievement, it's printing SHINY_PARTY.description Well then it is not working correct
> @CodeTappert any ideas? This PR fixes it: https://github.com/josericardo-fo/pokerogue/pull/5
> > > @CodeTappert any ideas? > > > > > > This PR fixes it: [josericardo-fo#5](https://github.com/josericardo-fo/pokerogue/pull/5) > > 🙌 Ähm...You merged it into your main.
Merge this to revert the merge in main: https://github.com/josericardo-fo/pokerogue/pull/7 Here is a merge to the correct branch: https://github.com/josericardo-fo/pokerogue/pull/6
Well you probably read it in the dev-corner. The size of the achivment bar should scale by its content. Only then will it be merged. @Dakurei will also try to...
I added a new PR to your project that now implements the size based on content. Here is a video showing it: https://github.com/pagefaultgames/pokerogue/assets/38758606/00a10fdd-85f4-4001-a3a1-0ea07b425419