Jannik Tappert

Results 219 comments of Jannik Tappert

Does Kirlia need an item to evolve to gallade currently (in pokerouge) If not this might explain why is it set that way. https://github.com/pagefaultgames/pokerogue/blob/6fa7412465b99d38944c124ec49d52b010d8d5c7/src/data/pokemon-evolutions.ts#L429

Okay i looked more at the code. I mean we could really implement it the way it is in the games. I dont see a code reason not to do...

I agree with @Xavion3 To change the code is quite easy. (to make it like the games for example). But this will nerve the formes that require a stone. If...

As stated in https://github.com/pagefaultgames/pokerogue/issues/1101#issuecomment-2118914942 by Xavion3. The devs will discuss what should be done about it and how or if it should be changed. Please wait for that decision

Test (with german locailzation): (see https://github.com/dakurei-forks/pokerogue/pull/1 pleaes merge it into this :D) - ![image](https://github.com/pagefaultgames/pokerogue/assets/38758606/7aa03a70-5ea3-4f55-a321-f6b4ef6357bf) - ![image](https://github.com/pagefaultgames/pokerogue/assets/38758606/8e9cd82b-ea34-4215-8af7-eba1ed86b4bc) - ![image](https://github.com/pagefaultgames/pokerogue/assets/38758606/3e38d3f5-b78e-43cb-aa67-00be8f960a0a) English: - ![image](https://github.com/pagefaultgames/pokerogue/assets/38758606/86322e98-052f-4720-871a-e027c1d89d37) - ![image](https://github.com/pagefaultgames/pokerogue/assets/38758606/bbe24997-1ad7-4c60-b46f-c1537e0784ff) - ![image](https://github.com/pagefaultgames/pokerogue/assets/38758606/a085a79a-ebb2-4706-84eb-b998113b6265) Works fine as expected

Well according to https://bulbapedia.bulbagarden.net/wiki/Galar_League you fight always Marnie, Hop, (Bede - he is officially not part so i dont know if we include it), Nessa, (Bea or Allister depending on...

> That sounds fine, I don't know about the type theme tho, I would avoid reusing gym leaders in elite four whenever possible to add more variety and potentially more...

De Translation: ```ts "TrainerBattleChanceBoosterModifierType": { description: "Verdoppelt für {{battleCount}} Kämpfe die Chance auf einen Trainerkampf", }, "REPEL": { name: "Schutz" }, "SUPER_REPEL": { name: "Superschutz" }, "MAX_REPEL": { name: "Top-Schutz"...

> Not having the `window.location.hostname === ''` check breaks the offline detection for local files, such as from my app :( You mean for compiled files? Because this change works...

> This is indeed back to working. Also yeah, my app is serving compiled files and registers as an empty string for that check for whatever reason; I don't know...