pagefaultgames
Changed How is local is checked and how serverURL is build to prevent…
Not having the
window.location.hostname === ''check breaks the offline detection for local files, such as from my app :(
You mean for compiled files? Because this change works fine when run via "npm start dev".
Even if you serve dist folder it should work without problems
This is indeed back to working. Also yeah, my app is serving compiled files and registers as an empty string for that check for whatever reason; I don't know the details behind it, but that is what happens for it. My Android apk registers normally as localhost though.
This is indeed back to working. Also yeah, my app is serving compiled files and registers as an empty string for that check for whatever reason; I don't know the details behind it, but that is what happens for it. My Android apk registers normally as localhost though.
I readded the check for you
Yep, that's what I was talking about; it works fine for my app's particular offline now. Now it's just up to the actual devs to see what they think of this change for their purposes heh
As there were minor changes to the code, I tested this again and can confirm it fixes #1078
This PR is ready to be reviewed/merged by a dev.
Walker says this is fine. See https://discord.com/channels/1125469663833370665/1243948971110694982
Now it is consistent and breaks after || or && if it would be to long without the break