Calum Murray
Calum Murray
cc @pierDipi @creydr @Leo6Leo any thoughts on what approach we should take here? One of the options above, some other option?
@pierDipi this metrics problem is on the egress for IMC. So, I guess the fix is to change how we count and emit metrics in the imc-dispatcher?
> I think re-using the new filters API for this specific source makes sense: https://knative.dev/docs/eventing/experimental-features/new-trigger-filters/ It is a more powerful filtering mechanism than just types and will also provide UX...
> Maybe that was the intention of the blog post but to me it felt that it ended abruptly. I didn't "see" any result or output. @nainaz that's a great...
Thanks for all of your help with this @aliok!!
/test reconciler-tests
/test reconciler-tests
> Sounds good, I wrote some unit tests but they are not passing :( If you push your code I can also take a look!
> I think the error is raised from the checknamespace validation function, but I'm not sure how to add user info in the test case? Hey @yijie-04 - I think...
Whoops @yijie-04 it looks like your expected subject access review in the tests also needs to have the groups field set (since we un commented that line in the actual...