Calum Murray
Calum Murray
@yijie-04 this looks really good so far! Would you be able to also add some unit tests to the trigger validation, similar to what you did for the subscription?
I like this idea, maybe we can provide a `.spec.sinkEnvVar` and a `.spec.ceOverridesEnvVar` field, where users can specify the name of the env vars for the sinkbinding.
@pierDipi : > Note: You must create custom environment variables beginning with REACT_APP_. Any other variables except NODE_ENV will be ignored to avoid accidentally [exposing a private key on the...
@pierDipi I can't recall if we made a decision on how to approach this issue/if we should do this (maybe in combination with https://github.com/knative/eventing/issues/5749). Do you know what decision was...
> How can I get the reconciler-test image uploaded and used? I tried with ko build vendor/knative.dev/reconciler-test/cmd/eventshub but it has some problems too: @rh-hemartin can you try running `./test/upload-test-images.sh` ?
/test reconciler-tests
@pierDipi @creydr I don't think I'll have time to keep debugging the KinD test jobs, would either of you want to pick up this PR or should I just close...
@Leo6Leo maybe instead of bloating the shell scripts, we can add a check into the test entry point on the go side, then we can call https://github.com/knative/pkg/blob/main/version/version.go#L52 (which is what...
My personal vote here is to go with option 1 from above, as that way: 1. the event count will be correct 2. I can create other aggregate views of...