Calum Murray

Results 362 comments of Calum Murray

/cc @Leo6Leo @pierDipi @creydr This is just WIP until I add unit tests (probably tomorrow), so the actual changes are ready for a review!

` rbac.go:40: an error on the server ("Internal Server Error: \"/apis/rbac.authorization.k8s.io/v1/namespaces/test-ngogqfqt/rolebindings/subscriber-walrgdtq\": the server is currently unable to handle the request") has prevented the request from succeeding` Looks like GKE issues...

/cc @Leo6Leo @creydr @pierDipi This is ready for review now

Whoops @pierDipi looks like this somehow got merged before I could address your feedback. I'll open a follow up PR later today to try and make the changes you asked...

/help /triage accepted

Hi @erharjotsingh what we are looking to do is map the golang types that I linked above for the SubscriptionsApi Filters into a `filters` field in the trigger CRD (also...

@duglin I believe @dgeorgievski has offered to contribute a PR for this

I believe this is complete now, closing here...