Calum Murray

Results 362 comments of Calum Murray

> lister is not in sync. But: we have multiple reconcilations, so at some point it should be updated... @pierDipi @creydr maybe we could do something similar to what we...

@pierDipi with `v1beta2` being stored now, I _think_ so, but I would like to check & maybe add a test to verify. Thanks for the ping here!

> AFAIK, the new version has some API changes on the types and I don't see them reflected here yet https://github.com/knative/eventing/blob/main/pkg/apis/eventing/v1beta3/eventtype_types.go, I guess we need to start with that first...

Hey @Leo6Leo anything I can help with on this PR?

@Leo6Leo is there a plan to add a rekt test for this feature? Maybe in another PR?

@Leo6Leo I think it's worth still having a "default" class available, just maybe not also a config. Then the default class is just referring to the one of the classes...

@aliok I would be happy to help on making this POC