Calum Murray comments

Results 362 comments of


                                            Calum Murray

EventType Automatic Registration support for PingSource

/unassign

[Experimental] Enhanced Trigger filters via adopting CloudEvent Subscriptions API

/assign

[Experimental] Enhanced Trigger filters via adopting CloudEvent Subscriptions API

@pierDipi how many releases should we wait here before starting to move it to GA?

[Experimental] Enhanced Trigger filters via adopting CloudEvent Subscriptions API

Hi @hamishforbes thanks for catching this! Because the trigger CRD hasthe `x-kubernetes-preserve-unknown-fields: true` property, you can just add the `filters` field to your triggers and it should work. I hadn't...

[Broker/Trigger] Make it easier to consume events directly from specific sources

@pierDipi I'm going to loop in the UX group here in case people have opinions about the UX of the ideas discussed so far /cc @knative/ux-wg-leads

CESQL: clarify behaviours of errors in OR expressions

Yes, I believe so. Thanks!

Clarify whether missing attributes should return an `error` or `false`

@duglin could you assign this to me?

Clarify whether missing attributes should return an `error` or `false`

Interesting, from the spec it seems like: > When addressing an attribute not included in the input event, an empty _String_ MUST be assumed as its value. IMO this seems...

Clarify that missing attributes should not result in errors

Hmm you bring up a good point @duglin - one other option would be to have the missing attribute cast to the "default" value for the SINGLE expression it is...

Clarify that missing attributes should not result in errors

@duglin I think I like the idea of the current single operation returning `false`. > e.g. xxx="" might need to be: `not(exists(xxx)) or xxx=""` if they want "missing" to be...