docs
docs copied to clipboard
Intro to open source with knative blog series p3
This PR contains a draft of the first post in the blog series we proposed recently to make it easier for new contributors to contribute code. The proposal can be seen here
Proposed Changes
- Create post 3: API Changes
Deploy Preview for knative ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 9f7f92c5915f8ee50b7454b41e739372e9f40606 |
| Latest deploy log | https://app.netlify.com/sites/knative/deploys/66588fc168cf4500083580d7 |
| Deploy Preview | https://deploy-preview-5949--knative.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/cc @Cali0707 @pierDipi @creydr
Great start and left some comments. Maybe that was the intention of the blog post but to me it felt that it ended abruptly. I didn't "see" any result or output. I just changed a file, got suggestion to change the other file but then to what end.
Maybe that was the intention of the blog post but to me it felt that it ended abruptly. I didn't "see" any result or output.
@nainaz that's a great point, we should probably improve the conclusion a bit
The idea is that readers would then continue to the future blog posts we are working on and make the rest of the required changes there. But, I can see how that could be unclear or leave someone unsatisfied reading the current post.
Making it more clear would be helpful. I probably missed the last piece of the blog. I still think adding what would this "change" ultimately accomplish would be better Thank you, -N
On Wed, 15 May 2024 at 10:13, Calum Murray @.***> wrote:
Maybe that was the intention of the blog post but to me it felt that it ended abruptly. I didn't "see" any result or output.
@nainaz https://github.com/nainaz that's a great point, we should probably improve the conclusion a bit
The idea is that readers would then continue to the future blog posts we are working on and make the rest of the required changes there. But, I can see how that could be unclear or leave someone unsatisfied reading the current post.
— Reply to this email directly, view it on GitHub https://github.com/knative/docs/pull/5949#issuecomment-2112666052, or unsubscribe https://github.com/notifications/unsubscribe-auth/AISZCFAB7NEDST5CMMJD4SLZCNURNAVCNFSM6AAAAABGY3RKO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGY3DMMBVGI . You are receiving this because you were mentioned.Message ID: @.***>
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Cali0707, Leo6Leo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Cali0707,Leo6Leo]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment