Ruben Bridgewater
Ruben Bridgewater
Seems like this is doing something similar to https://github.com/DataDog/dd-trace-js/pull/4819?
@joyeecheung due to the CI constantly failing due to the heapdumps now dying, do you think this could already land in it's current form knowing that it does not yet...
We use it to align the behavior with express 4.x. Express 5.x support is currently not 100% aligned. May I ask about the use case?
In that case, the actual fix for this is probably not an update to `path-to-regexp` but an improved express v5 instrumentation on our side. @sheplu I believe you wanted to...
I'll go ahead and close this for now since it has been open for quite a while. Please feel free to reopen in case you would like to continue work...
What's the status here? :) Should we address this differently or table it for now?
I added the tsc label to discuss, if we want to allow users to read such big files into memory, or if it would be better to try to point...
@gireeshpunathil I believe you wanted to think about the warning again. I kept my change request since the implementation should also include the callback version next to the warning. That's...
While I generally believe it's good to align behavior when it deviates, I would not expect the hashing algorithm to be important for someone to handle the value. Any value...
@watson that makes sense. Standard is sadly not properly maintained since a long time. +1 on removing it. Should we just do it in this PR?