Ruben Bridgewater
Ruben Bridgewater
Ping @szegedi
@szegedi PTAL, I believe this got superseded by https://github.com/DataDog/dd-trace-js/pull/5743
@rochdev is this something you would still like to work upon?
I think we should get back to this, when we really need it. Using the sandbox has an overhead and I do not remember issues around code having a negative...
I am closing this for now to limit the surface of things we are currently working on. Please open this again when coming back to it.
I am uncertain why the requirements json test fails.
Merge commits are always tricky. You always have to do a compromise in this case. The merge commit itself should however not count, just the commits that it references.
Theoretically, the merging person could be counted but they might not have changed any code. That is the reason why I would not count them.
Are we already certain that it's only related to merge commits? I personally would like to see concrete simplified examples of situations that are not working as intended to see...
This needs a rebase