Ruben Bridgewater comments

Results 323 comments of


                                            Ruben Bridgewater

fs: improve `cpSync` dest overriding performance

You are absolutely correct! I misread. Please ignore my comment :)

Testing optout iast into appsec

This seems rather outdated. @uurien is this something you would still like to work on? I would otherwise go ahead and close this.

Help the user see where the line is interpolated due to missing/delayed data

What is the status here?

Node.js's Discord Roles (Sync)

I think someone from the foundation or the tsc should have owner rights for example with a neutral admin account. Besides that I have no strong opinion and I am...

rename master to main

I just updated the PR. Please have another look

rename master to main

Superseded

Improve map navigation

I believe this is unblocked due to #3077 landing, I am not completely certain though. Maybe someone could check that?

Update npm to v11 in Node.js v22

I believe we should backport the update to Node.js v22. We know about the difficulty with the support ranges and this was the way we handled it before. The breaking...

fix child_process propagation issues

All of these tests pass with the current implementation while other tests fail with the change. Due to that and the age of the draft, I'll close this. I guess...

remove st.js script

I"ll go ahead and close this as outdated, since it only removes the script without any other change and it would be easy to recreate that. Feel free to open...