dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

[FEATURE]: Bump path-to-regexp

Open bipin-pp opened this issue 8 months ago • 3 comments

Package Name

No response

Package Version(s)

No response

Describe the feature you'd like

There is much higher version (8.x) of path-to-regexp available. Are there plans to bump it?

Is your feature request related to a problem?

No response

Describe alternatives you've considered

No response

Additional context

No response

bipin-pp avatar Jun 12 '25 11:06 bipin-pp

We use it to align the behavior with express 4.x. Express 5.x support is currently not 100% aligned. May I ask about the use case?

BridgeAR avatar Jun 12 '25 11:06 BridgeAR

We use it to align the behavior with express 4.x. Express 5.x support is currently not 100% aligned. May I ask about the use case?

I am trying to bump express 4 to express 5, unable to use optional using question mark (?) in path.

Image

bipin-pp avatar Jun 16 '25 14:06 bipin-pp

In that case, the actual fix for this is probably not an update to path-to-regexp but an improved express v5 instrumentation on our side.

@sheplu I believe you wanted to have a look at the v5 implementation? :)

BridgeAR avatar Jun 16 '25 22:06 BridgeAR