Ruben Bridgewater comments

Results 323 comments of


                                            Ruben Bridgewater

centralize ci action versions

Ping @rochdev

Fix KafkaJS instrumentation of orphaned promise

@mastermatt thanks for the PR and the ping, I am going to try to take a look at it tomorrow. It is strongly appreciated that you opened the PR with...

Fix KafkaJS instrumentation of orphaned promise

I work on it in https://github.com/DataDog/dd-trace-js/pull/5837. There seems to be another issue about potentially manipulating input data and I optimize the code for higher performance as well.

Allow collaborators to share Github Sponsors link in project readme

SGTM Adding it to the website and or the readme.

[feature-request]: `node-fetch` doesn't create `http.request` spans

dd-trace-js has no support for node-fetch so far. We do support the native Node.js fetch, so that's why the traces show up when using that instead. Is there a strong...

[feature-request]: `node-fetch` doesn't create `http.request` spans

Thanks, that makes sense. I don't think we will be able to introduce support for it anytime soon though (if at all). The only way I see it happening anytime...

repl: add possibility to edit multiline commands while adding them

> interesting, I cannot replicate the issue (we also have a specific test for this). What I am doing to test the behavior is to paste this I just had...

Getting TraceID from an OpenTracing DatadogSpanContext can throw "Cannot read properties of undefined (reading 'toString')

@remijacquarthublo I guess you are using a never version than 5.36.0 or 5.36.0? Could you please post the concrete error and as much additional information as you have? :)

Getting TraceID from an OpenTracing DatadogSpanContext can throw "Cannot read properties of undefined (reading 'toString')

Closing, since this got fixed in 5.36.0

[WIP] Cap and update versions in CI

I very much like the overall idea here. Is that still worked upon?