dd-trace-js
dd-trace-js copied to clipboard
Add _dd.integration to spans to calculate internal stats
What does this PR do?
This PR adds _dd.integration tag to all the spans containing the integration name. While the component tag could have the same information, there is no guarantee about the content of the component tag since it can be modified by the user.
This one is internal and the user cannot change it.
We are changing all the tracers to infer this information in order to calculate stats upstream around integration usage
Motivation
Plugin Checklist
- [x] Unit tests.
- [ ] Integration tests.
- [ ] Benchmarks.
- [ ] TypeScript definitions.
- [ ] TypeScript tests.
- [ ] API documentation.
- [ ] CI jobs/workflows.
Additional Notes
Overall package size
Self size: 9.62 MB Deduped: 106.13 MB No deduping: 106.65 MB
Dependency sizes
| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.8.2 | 9.56 MB | 9.93 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe
Codecov Report
Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
Project coverage is 79.46%. Comparing base (
c1d66b7) to head (af07c4e). Report is 8 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| packages/dd-trace/src/plugins/util/web.js | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #5652 +/- ##
==========================================
- Coverage 79.56% 79.46% -0.11%
==========================================
Files 476 474 -2
Lines 20306 20168 -138
==========================================
- Hits 16157 16027 -130
+ Misses 4149 4141 -8
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Datadog Report
Branch report: andrea.marziali/component-stat
Commit report: b819bc5
Test service: dd-trace-js-integration-tests
:white_check_mark: 0 Failed, 1257 Passed, 0 Skipped, 21m 50.65s Total Time
Benchmarks
Benchmark execution time: 2025-06-30 07:14:41
Comparing candidate commit af07c4eb1dae004e9fba22b3f0d468fa57877e7b in PR branch andrea.marziali/component-stat with baseline commit c1d66b770f2222be80f563ddaaaad3f479593480 in branch master.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 1270 metrics, 53 unstable metrics.
What's the status here? :) Should we address this differently or table it for now?
What's the status here? :) Should we address this differently or table it for now?
I forgot to draft it. I still need to work on it. I converted to draft since, it does not look sufficient