feat(linter): add `eslint/dot-notation`
Relates to #479
Rule details: https://eslint.org/docs/latest/rules/dot-notation
How to use the Graphite Merge Queue
Add either label to this PR to merge it via the merge queue:
- 0-merge - adds this PR to the back of the merge queue
- hotfix - for urgent hot fixes, skip the queue and merge this PR next
You must have a Graphite account in order to use the merge queue. Sign up using this link.
An organization admin has enabled the Graphite Merge Queue in this repository.
Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.
I think there are some possible improvements. One is: instead of VALID_IDENTIFER: Regex there can be a simple char parser.
@camchenry @shulaoda you guys have more knowledge about performance in rust
I think there are some possible improvements. One is: instead of
VALID_IDENTIFER: Regexthere can be a simple char parser.
Perhaps we can take inspiration from https://github.com/rolldown/rolldown/pull/3677. I’ll review it later.
CodSpeed Performance Report
Merging #9344 will not alter performance
Comparing ammubhave:dot-notation (d8858e2) with main (44fd2c4)
Summary
✅ 33 untouched benchmarks
@camc314 would be great if you can finish this, by copying over what the minifier does.